common.Device: replace model.Device with common.Device #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous set of changes - 408ed07, the common.Device{} object was embedded in model.Device{} to continue including the OemComponents field for OEM hardware. This change moves the OemComponents field into the Hardware{} object and so the model.Device{} object is removed and ironlib will now return a common.Device{} for consistency with bmclib.
diogomatsubara
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous set of changes - 408ed07, the common.Device{} object
was embedded in model.Device{} to continue including the OemComponents field
for OEM hardware. This change moves the OemComponents field into
the Hardware{} object and so the internal model.Device{} object is removed completely
and ironlib will now return a common.Device{} for consistency with bmclib.