Skip to content

Commit

Permalink
unit tests and linters fix
Browse files Browse the repository at this point in the history
Signed-off-by: Himanshu Roy <hroy@redhat.com>
  • Loading branch information
hroyrh committed Apr 15, 2024
1 parent f6afc45 commit cd843d0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion controllers/metal3.io/dataimage_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func (r *DataImageReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
if err != nil || !ready {
var msg string
if err == nil {
msg = "not ready"
msg = "Not ready"
} else {
msg = err.Error()
}
Expand Down
10 changes: 5 additions & 5 deletions pkg/provisioner/ironic/clients/features_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
)

func TestAvailableFeatures_ChooseMicroversion(t *testing.T) {
microVersion := "1.86"
microVersion := "1.89"
type fields struct {
MaxVersion int
}
Expand All @@ -16,21 +16,21 @@ func TestAvailableFeatures_ChooseMicroversion(t *testing.T) {
want string
}{
{
name: fmt.Sprintf("MaxVersion < %d return microversion %s", 86, baseline),
name: fmt.Sprintf("MaxVersion < %d return microversion %s", 89, baseline),
feature: fields{
MaxVersion: 50,
},
want: baseline,
},
{
name: fmt.Sprintf("MaxVersion = %d return %s", 86, microVersion),
name: fmt.Sprintf("MaxVersion = %d return %s", 89, microVersion),
feature: fields{
MaxVersion: 86,
MaxVersion: 89,
},
want: microVersion,
},
{
name: fmt.Sprintf("MaxVersion > %d return %s", 86, microVersion),
name: fmt.Sprintf("MaxVersion > %d return %s", 89, microVersion),
feature: fields{
MaxVersion: 100,
},
Expand Down

0 comments on commit cd843d0

Please sign in to comment.