Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Stop using Inspector API for inspection status #1260

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Apr 25, 2023

Ironic provides enough information, we need to get rid of direct
Inspector calls eventually. This change significantly simplifies
the logic by using the existing call to fetch data to detect when
an inspection still needs to be started.

Add a missing unit test for the refresh argument.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2023
@dtantsur
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@dtantsur
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@dtantsur
Copy link
Member Author

/test-centos-e2e-integration-main

1 similar comment
@dtantsur
Copy link
Member Author

/test-centos-e2e-integration-main

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2023
Ironic provides enough information, we need to get rid of direct
Inspector calls eventually. This change significantly simplifies
the logic by using the existing call to fetch data to detect when
an inspection still needs to be started.

Add a missing unit test for the refresh argument.
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2023
@dtantsur
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@derekhiggins
Copy link
Member

/lgtm

@metal3-io-bot
Copy link
Contributor

@derekhiggins: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@honza
Copy link
Member

honza commented Sep 14, 2023

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@zaneb
Copy link
Member

zaneb commented Sep 18, 2023

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@metal3-io-bot metal3-io-bot merged commit 6c8213e into metal3-io:main Sep 18, 2023
10 checks passed
@dtantsur dtantsur deleted the no-inspect-status branch September 18, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants