-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Stop using Inspector API for inspection status #1260
Conversation
/test-centos-e2e-integration-main |
1424a0a
to
8185ec9
Compare
/test-centos-e2e-integration-main |
/test-centos-e2e-integration-main |
1 similar comment
/test-centos-e2e-integration-main |
Ironic provides enough information, we need to get rid of direct Inspector calls eventually. This change significantly simplifies the logic by using the existing call to fetch data to detect when an inspection still needs to be started. Add a missing unit test for the refresh argument.
8185ec9
to
b535bed
Compare
/test-centos-e2e-integration-main |
/lgtm |
@derekhiggins: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ironic provides enough information, we need to get rid of direct
Inspector calls eventually. This change significantly simplifies
the logic by using the existing call to fetch data to detect when
an inspection still needs to be started.
Add a missing unit test for the refresh argument.