Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Reduce the preprovisioning image retry delay #1275

Merged
merged 1 commit into from
May 25, 2023
Merged

🌱 Reduce the preprovisioning image retry delay #1275

merged 1 commit into from
May 25, 2023

Conversation

dtantsur
Copy link
Member

Five minutes is a lot. Neither the built-in image provider nor the one
we have in OpenShift takes so much to build images.

@dtantsur
Reduce the preprovisioning image retry delay
171181d 
Five minutes is a lot. Neither the built-in image provider nor the one
we have in OpenShift takes so much to build images.
@dtantsur dtantsur requested a review from zaneb May 16, 2023 12:40
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 16, 2023
@dtantsur
Copy link
Member Author

/test golint
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@dtantsur
Copy link
Member Author

/test-centos-e2e-integration-main

@zhouhao3
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
@dtantsur
Copy link
Member Author

/test-centos-e2e-integration-main

1 similar comment
@elfosardo
Copy link
Member

/test-centos-e2e-integration-main

@honza
Copy link
Member

honza commented May 25, 2023

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza, MahnoorAsghar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@metal3-io-bot metal3-io-bot merged commit 8a7edfb into metal3-io:main May 25, 2023
@dtantsur dtantsur deleted the preprov-delay branch May 25, 2023 14:43
@zaneb
Copy link
Member

zaneb commented May 25, 2023

Hold on, the controller is watching the PreprovisioningImage so it will be notified immediately when something changes.
This delay is for how long before we pointlessly requeue the BMH when nothing has changed. If anything it should maybe be longer than 5 minutes so that we don't pointlessly hammer the API when e.g. the preprovisioning image controller is down.
I think we should revert this.

@dtantsur dtantsur mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MahnoorAsghar MahnoorAsghar MahnoorAsghar approved these changes

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dtantsur @zhouhao3 @elfosardo @honza @metal3-io-bot @zaneb @MahnoorAsghar