Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 fix issue with git directory ownership in golint #1349

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Sep 1, 2023

Run docker as same uid as user, so Git doesn't complain about directory ownership. This makes linting work locally as well.

Run docker as same uid as user, so Git doesn't complain about directory
ownership. This makes linting work locally as well.
@tuminoid
Copy link
Member Author

tuminoid commented Sep 1, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2023
@tuminoid tuminoid changed the title 🌱 fix issue with git safe repository protections 🌱 fix issue with git directory ownership in golint Sep 1, 2023
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
@tuminoid
Copy link
Member Author

tuminoid commented Sep 1, 2023

/assign @kashifest

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@metal3-io-bot metal3-io-bot merged commit 5042de2 into metal3-io:main Sep 4, 2023
@tuminoid tuminoid deleted the tuomo/fix-local-golint branch September 4, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants