Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 fix releasing.md on annotated tags #1365

Merged
merged 1 commit into from
Sep 26, 2023
Merged

📖 fix releasing.md on annotated tags #1365

merged 1 commit into from
Sep 26, 2023

Conversation

tuminoid
Copy link
Member

-m also implies -a, so neither of them can be present.

@tuminoid
fix releasing.md on annotated tags
9714d1e 
-m also implies -a, so neither of them can be present.
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2023
@tuminoid
Copy link
Member Author

/override test-ubuntu-integration-main
/override test-centos-e2e-integration-main

Integration tests do not relate to documentation. Save trees.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main
/override test-centos-e2e-integration-main

Integration tests do not relate to documentation. Save trees.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lentzi90
lentzi90 reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@smoshiur1237
Copy link
Member

LGTM

@tuminoid
Copy link
Member Author

/assign @kashifest

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@metal3-io-bot metal3-io-bot merged commit 97abcb2 into metal3-io:main Sep 26, 2023
5 checks passed
@tuminoid tuminoid deleted the tuomo/fix-releasing-doc branch September 26, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

Assignees

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @metal3-io-bot @smoshiur1237 @kashifest @lentzi90