Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Add "empty" profile and officially deprecate hardware profiles #1381

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Oct 5, 2023

See the design proposal metal3-io/metal3-docs#332

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 5, 2023
@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@dtantsur
Copy link
Member Author

dtantsur commented Oct 5, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@hardys
Copy link
Member

hardys commented Oct 6, 2023

lgtm

@zaneb
Copy link
Member

zaneb commented Oct 16, 2023

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@metal3-io-bot metal3-io-bot merged commit da45eff into metal3-io:main Oct 16, 2023
10 checks passed
@dtantsur dtantsur deleted the empty-profile branch October 17, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants