Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fixing ensure-go script to allow go versions greater than MINIMUM_GO_VERSION #1405

Merged
merged 1 commit into from
Oct 27, 2023
Merged

🌱 Fixing ensure-go script to allow go versions greater than MINIMUM_GO_VERSION #1405

merged 1 commit into from
Oct 27, 2023

Conversation

adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Oct 26, 2023 •
edited
Loading

What this PR does / why we need it:
Right now ensure_go.sh gives an error while e2e tests locally even when the go version is greater than MINIMUM_GO_VERSION which is wrong. This PR is fixing it, we already have this script working in CAPM3, this PR is just taking code from there. Check here: https://github.com/metal3-io/baremetal-operator/blob/783eb742630067146b4b98173c32a3d96348778a/hack/e2e/ensure_go.sh#L25C12-L25C12

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2023
@lentzi90
Copy link
Member

/metal3-bmo-e2e-test

lentzi90
lentzi90 reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
tuminoid
tuminoid requested changes Oct 26, 2023
View reviewed changes
hack/e2e/ensure_go.sh Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@lentzi90
Copy link
Member

/metal3-bmo-e2e-test

lentzi90
lentzi90 reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Can you update the same code in CAPM3 @adilGhaffarDev ?

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
kashifest
kashifest reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@honza
Copy link
Member

honza commented Oct 26, 2023

It would be great if we could outline how we are fixing the script in the commit message.

@kashifest
Copy link
Member

It would be great if we could outline how we are fixing the script in the commit message.

/hold
Good point!

@kashifest
Copy link
Member

Come on now prow!

/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 26, 2023
@adilGhaffarDev
Copy link
Member Author

It would be great if we could outline how we are fixing the script in the commit message.

It sorts the local go version and MINIMUM_GO_VERSION in ascending order and then compares the first element in ascending order list with MINIMUM_GO_VERSION and if they are not equal, it returns an error. It is also checking that local go is not "devel" version.

@adilGhaffarDev adilGhaffarDev mentioned this pull request Oct 26, 2023
Merged
@adilGhaffarDev
Copy link
Member Author

@kashifest updated description also answered @honza 's question.

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@adilGhaffarDev adilGhaffarDev changed the title 🌱 Fixing ensure go script 🌱 Fixing ensure-go script to allow go versions greater than MINIMUM_GO_VERSION Oct 27, 2023
lentzi90
lentzi90 reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@lentzi90
Copy link
Member

These are not relevant
/override test-ubuntu-integration-main
/override test-centos-e2e-integration-main

This one is
/metal3-bmo-e2e-test

@metal3-io-bot
Copy link
Contributor

@lentzi90: lentzi90 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

These are not relevant
/override test-ubuntu-integration-main
/override test-centos-e2e-integration-main

This one is
/metal3-bmo-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member

These are not relevant
/override test-ubuntu-integration-main
/override test-centos-e2e-integration-main

This one is
/metal3-bmo-e2e-test

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

These are not relevant
/override test-ubuntu-integration-main
/override test-centos-e2e-integration-main

This one is
/metal3-bmo-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member

@kashifest updated description also answered @honza 's question.

Thanks
/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2023
@metal3-io-bot metal3-io-bot merged commit 7fefacd into metal3-io:main Oct 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@kashifest kashifest kashifest left review comments

@tuminoid tuminoid tuminoid approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adilGhaffarDev @lentzi90 @metal3-io-bot @honza @kashifest @tuminoid