🐛 Log node updates with a normal logger

[dtantsur]

No description provided.

[dtantsur]

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

[zaneb]

This is going to get pretty chatty. Every single bit of data we write to ironic will get logged. I'm not sure we want that.
I would support adding a separate -debug CLI flag so that the level can be set independently of the other side effects of the -dev flag (which also disables structured logging).

[dtantsur]

This is going to get pretty chatty. Every single bit of data we write to ironic will get logged. I'm not sure we want that.

Yes, we absolutely do want that. This is much less chatty that the stuff we already log. If you take a look at what we log, you'll see what I mean. The reason for proposing this patch is a bug where BMO gets stuck trying to update deploy_interface on an externally provisioned node - an operation that just should not happen, but it does, and I don't even know what the values are. So, while I support the idea of having the debug flag, this is one of the first things that must never be covered by it.

[dtantsur]

Here are some numbers from the recent run:

$ grep "option data" ~/Work/stdout.log | wc -l
85

which may seem a lot, but it's less than 4% of all messages. For contrast:

$ grep "registering and validating access" ~/Work/stdout.log | wc -l
175
$ grep controllers.BMCEventSubscription ~/Work/stdout.log | wc -l
134

... and the CI does not even use BMC subscriptions!

[elfosardo]

/lgtm

[zaneb]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zaneb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment