🌱 Add github workflow for e2e fixture tests #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/S
maxrantil
changed the title
metal3-io-bot
added
the
do-not-merge/work-in-progress
maxrantil
force-pushed
the
add-fixture-tests-to-CI/max
branch
3 times, most recently
from
e13dce3
to
99dd94a
Compare
metal3-io-bot
added
size/M
maxrantil
force-pushed
the
add-fixture-tests-to-CI/max
branch
from
99dd94a
to
89ef8e8
Compare
metal3-io-bot
added
size/S
maxrantil
force-pushed
the
add-fixture-tests-to-CI/max
branch
3 times, most recently
from
cf070b4
to
370de00
Compare
metal3-io-bot
added
size/M
maxrantil
force-pushed
the
add-fixture-tests-to-CI/max
branch
5 times, most recently
from
478c56e
to
ab9ee4b
Compare
metal3-io-bot
added
size/S
maxrantil
force-pushed
the
add-fixture-tests-to-CI/max
branch
from
ab9ee4b
to
fc20642
Compare
metal3-io-bot
added
size/M
maxrantil
force-pushed
the
add-fixture-tests-to-CI/max
branch
3 times, most recently
from
e4bff1d
to
b16908b
Compare
metal3-io-bot
removed
the
size/M
|
/metal3-bmo-e2e-test |
|
/test-centos-e2e-integration-main |
metal3-io-bot
added
the
do-not-merge/hold
maxrantil
force-pushed
the
add-fixture-tests-to-CI/max
branch
from
91b0184
to
e71b1ae
Compare
tuminoid
reviewed
Nov 13, 2023
|
/unhold |
metal3-io-bot
removed
the
do-not-merge/hold
maxrantil
force-pushed
the
add-fixture-tests-to-CI/max
branch
from
e71b1ae
to
b7a3e37
Compare
|
/metal3-bmo-e2e-test |
|
/test-centos-e2e-integration-main |
mquhuy
reviewed
Nov 14, 2023
Implement lightweight fixture-based tests to ensure CI platform flexibility.
maxrantil
force-pushed
the
add-fixture-tests-to-CI/max
branch
from
b7a3e37
to
d76e42e
Compare
|
/metal3-bmo-e2e-test |
|
/test-ubuntu-integration-main |
kashifest
reviewed
Nov 15, 2023
| @@ -33,7 +33,7 @@ intervals: | |||
| default/wait-registering: ["1m", "5s"] | |||
| inspection/wait-registration-error: ["1m", "5s"] | |||
| external-inspection/wait-available: ["20s", "1s"] | |||
| default/wait-inspecting: ["2m", "10s"] | |||
| default/wait-inspecting: ["2m", "2s"] | |||
There was a problem hiding this comment.
any reason to change this in this PR ?
There was a problem hiding this comment.
Using 10-second intervals means that it can miss the state, so I changed it to 2-seconds to make the test more robust.
There was a problem hiding this comment.
You are right to ask because I now see that this is in the ironic config, but after trying it out I noticed some flakes here so that why this fix is in this PR even that it has nothing to do with fixture.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implement lightweight fixture-based tests to ensure CI platform flexibility.
Fixes #1406