🐛 Don't munge timestamp in structured logs, again #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/XS
Structured logging tools expect a POSIX timestamp. 0a887a1 reverted to changing the timestamp formatting only in development log mode, after 9ecf171 had explicitly and unconditionally set the format to ISO-8601. However, almost immediately after this, 5bf0440 bumped the controller-runtime version from 0.13.1 to 0.14.5. In 0.14, the default zap options in controller-runtime changed to RFC3339 - which is the same as ISO-8601 but even worse because subsecond precision (which can be very important to debugging) is lost as well. This change explicitly restores the original default.
zaneb
force-pushed
the
logging-structured-timestamp-again
branch
from
bfd4503
to
4b8c581
Compare
|
/test-centos-e2e-integration-main |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structured logging tools expect a POSIX timestamp. 0a887a1 reverted to changing the timestamp formatting only in development log mode, after 9ecf171 had explicitly and unconditionally set the format to ISO-8601.
However, almost immediately after this, 5bf0440 bumped the controller-runtime version from 0.13.1 to 0.14.5. In 0.14, the default zap options in controller-runtime changed to RFC3339 - which is the same as ISO-8601 but even worse because subsecond precision (which can be very important to debugging) is lost as well.
This change explicitly restores the original default.