Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Implement Helper Functions for E2E Tests #1448

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

maxrantil
Copy link

What this PR does:
As the title says

Fixes #1436

@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2023
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
@maxrantil maxrantil force-pushed the e2e-helper-functions/max branch 3 times, most recently from 1329aed to 03c2b5e Compare November 17, 2023 12:45
@maxrantil
Copy link
Author

/metal3-bmo-e2e-test

@maxrantil
Copy link
Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@maxrantil
Copy link
Author

/test-centos-e2e-integration-main

@maxrantil
Copy link
Author

/metal3-bmo-e2e-test
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
Signed-off-by: Max Rantil <max.rantil@est.tech>
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
@maxrantil
Copy link
Author

/metal3-bmo-e2e-test
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@maxrantil
Copy link
Author

/test-centos-e2e-integration-main

@maxrantil
Copy link
Author

/cc @kashifest @dtantsur

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@kashifest kashifest changed the title ✨ Implement Helper Functions for E2E Tests 🌱 Implement Helper Functions for E2E Tests Nov 22, 2023
@metal3-io-bot metal3-io-bot merged commit 21384d9 into metal3-io:main Nov 22, 2023
16 checks passed
@metal3-io-bot metal3-io-bot deleted the e2e-helper-functions/max branch November 22, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Helper Functions to Streamline E2E Testing
5 participants