🐛 Fix htpasswd command not found #1486
Conversation
metal3-io-bot
added
the
size/S
|
/test-centos-e2e-integration-main |
|
/metal3-bmo-e2e-test |
| if ! [ -x "$(command -v htpasswd)" ]; then | ||
| echo "htpasswd could not be found, installing..." | ||
| sudo apt-get update | ||
| sudo apt-get install -y apache2-utils |
There was a problem hiding this comment.
not specific to this PR, but generally these hack/e2e/ scripts wont work locally for a mac user like me. I will add an issue to make it work for other architectures as well.
cc @lentzi90 @maxrantil
There was a problem hiding this comment.
Yes it would be great to make this more flexible so it can work also for development and not just CI. So far my focus has been to just set up the CI, but for the long term I definitely intend to make this easier for developers to use locally.
There was a problem hiding this comment.
I dis-asgree here. My understanding was the hack/ scripts are also used to test the CI test locally. If hack/e2e scripts are not meant to be used by developers locally, then I can agree.
I would ask that you do not make the CI unnecessarily complicated just to accommodate mac users though 😉
There was a problem hiding this comment.
Anyways, I have created an issue here anyhow #1487, lets discuss it on the issue.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/hold |
metal3-io-bot
added
the
do-not-merge/hold
peppi-lotta
force-pushed
the
fix/htpasswd-PEPPI
branch
from
b814bb7
to
05aad53
Compare
|
/hold cancel |
metal3-io-bot
removed
the
do-not-merge/hold
Signed-off-by: peppi-lotta <peppi-lotta.saari@est.tech>
peppi-lotta
force-pushed
the
fix/htpasswd-PEPPI
branch
from
05aad53
to
dfc7579
Compare
|
/test-centos-e2e-integration-main |
|
/override test-ubuntu-integration-main |
|
@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Fixes #1485