Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 reduce github actions permissions #1509

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 8, 2024

Move permissions from top-level to job-level as well.

Cleanup actions formatting to be the same for easier reading and maintenance. Add missing version tags.

These is highlighted by the CLOmonitor/OpenSSF Scorecard. This restores score for token permissions to 10/10.

/hold
until metal3-io/ip-address-manager#408 is reviewed and merged.

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 8, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Jan 9, 2024

Holding until dependabot in IPAM with new permissions has been tested. It should have some PRs next Monday at latest.

@tuminoid tuminoid force-pushed the tuomo/fix-actions-permissions branch 3 times, most recently from d1c611d to 8be26be Compare January 15, 2024 09:40
Move permissions from top-level to job-level as well.

Cleanup actions formatting to be the same for easier reading and
maintenance. Add missing version tags.

These is highlighted by the CLOmonitor/OpenSSF Scorecard. This restores
score for token permissions to 10/10.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/fix-actions-permissions branch from 8be26be to 7d05bbd Compare January 15, 2024 09:41
@tuminoid
Copy link
Member Author

/unhold

Lessons from IPAM PR were all taking in here, as well as the new image build job.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2024
@tuminoid
Copy link
Member Author

/override test-centos-e2e-integration-main test-ubuntu-integration-main metal3-bmo-e2e-test

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test, test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-e2e-integration-main test-ubuntu-integration-main metal3-bmo-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@metal3-io-bot metal3-io-bot merged commit 3f72dde into metal3-io:main Jan 15, 2024
16 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/fix-actions-permissions branch January 15, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants