-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 reduce github actions permissions #1509
🌱 reduce github actions permissions #1509
Conversation
Holding until dependabot in IPAM with new permissions has been tested. It should have some PRs next Monday at latest. |
d1c611d
to
8be26be
Compare
Move permissions from top-level to job-level as well. Cleanup actions formatting to be the same for easier reading and maintenance. Add missing version tags. These is highlighted by the CLOmonitor/OpenSSF Scorecard. This restores score for token permissions to 10/10. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
8be26be
to
7d05bbd
Compare
/unhold Lessons from IPAM PR were all taking in here, as well as the new image build job. |
/override test-centos-e2e-integration-main test-ubuntu-integration-main metal3-bmo-e2e-test |
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test, test-centos-e2e-integration-main, test-ubuntu-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Move permissions from top-level to job-level as well.
Cleanup actions formatting to be the same for easier reading and maintenance. Add missing version tags.
These is highlighted by the CLOmonitor/OpenSSF Scorecard. This restores score for token permissions to 10/10.
/hold
until metal3-io/ip-address-manager#408 is reviewed and merged.