Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add 'wait-power-state' interval to fixture test for flake fix #1551

Merged

Conversation

maxrantil
Copy link
Member

What this PR does / why we need it:
Add the interval 'wait-power-state' to our fixture test to fix a flake.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 12, 2024
@maxrantil maxrantil changed the title Add power interval to fixture/max 🌱 Add power interval to fixture/max Feb 12, 2024
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@maxrantil maxrantil changed the title 🌱 Add power interval to fixture/max 🌱 Add 'wait-power-state' interval to fixture test for flake fix Feb 12, 2024
Signed-off-by: Max Rantil <max.rantil@est.tech>
@maxrantil maxrantil force-pushed the add-power-interval-to-fixture/max branch from 2ed7e99 to 6be228c Compare February 12, 2024 13:15
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

Copy link
Member

@mboukhalfa mboukhalfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2024
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test-pull

1 similar comment
@maxrantil
Copy link
Member Author

/metal3-bmo-e2e-test-pull

@mquhuy
Copy link
Member

mquhuy commented Feb 12, 2024

/test metal3-bmo-e2e-test-pull

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
@metal3-io-bot metal3-io-bot merged commit 778a8e4 into metal3-io:main Feb 12, 2024
19 checks passed
@metal3-io-bot metal3-io-bot deleted the add-power-interval-to-fixture/max branch February 12, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants