Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Move e2e config functionality to a separate file #1593

Merged

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Mar 5, 2024

As titled. The e2e config related functionalities is growing, and we should have a separate file for it.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 5, 2024
@mquhuy mquhuy force-pushed the mquhuy/move-e2e-config-to-own-file branch 5 times, most recently from ca5d0b5 to 092ffd6 Compare March 5, 2024 03:33
Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/move-e2e-config-to-own-file branch from 092ffd6 to 43af089 Compare March 5, 2024 03:43
@mquhuy
Copy link
Member Author

mquhuy commented Mar 5, 2024

/test metal3-bmo-e2e-test-pull
/test metal3-bmo-e2e-test-optional-pull

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
@lentzi90
Copy link
Member

lentzi90 commented Mar 5, 2024

/test-centos-e2e-integration-main

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@metal3-io-bot metal3-io-bot merged commit e6c0679 into metal3-io:main Mar 5, 2024
20 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/move-e2e-config-to-own-file branch March 5, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants