Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 fix previous release detection in make release-notes #1597

Merged
merged 1 commit into from
Mar 5, 2024
Merged

📖 fix previous release detection in make release-notes #1597

merged 1 commit into from
Mar 5, 2024

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #1511

/assign tuminoid

@tuminoid
fix previous release detection in make release-notes
aa7071b 
We're overlapping our version numbers with really old version numbers,
ie. capm3-v0.4.1 vs v0.4.1 when using grep without line-start ^.
Fix the issue, so the correct previous tag is used in release
automation.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot mentioned this pull request Mar 5, 2024
Merged
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2024
@tuminoid
Copy link
Member

tuminoid commented Mar 5, 2024

/retitle 📖 fix previous release detection in make release-notes
/override test-centos-e2e-integration-release-1-5 test-ubuntu-integration-release-1-5

@metal3-io-bot metal3-io-bot changed the title [release-0.4] 📖 fix previous release detection in make release-notes 📖 fix previous release detection in make release-notes Mar 5, 2024
@metal3-io-bot
Copy link
Contributor Author

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-release-1-5, test-ubuntu-integration-release-1-5

In response to this:

/retitle 📖 fix previous release detection in make release-notes
/override test-centos-e2e-integration-release-1-5 test-ubuntu-integration-release-1-5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kashifest
kashifest reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
tuminoid
tuminoid reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@metal3-io-bot metal3-io-bot merged commit 5cec122 into metal3-io:release-0.4 Mar 5, 2024
11 of 12 checks passed
smoshiur1237
smoshiur1237 reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

Assignees

@tuminoid tuminoid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@metal3-io-bot @tuminoid @kashifest @smoshiur1237