Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump controller-runtime to v0.16.3 and CAPI to v1.6.4 #1678

Merged
merged 1 commit into from
Apr 17, 2024
Merged

🌱 Bump controller-runtime to v0.16.3 and CAPI to v1.6.4 #1678

merged 1 commit into from
Apr 17, 2024

Conversation

adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Apr 17, 2024 •
edited
Loading

What this PR does / why we need it:
Bump

  • Controller-runtime v0.16.3=>v0.16.5
  • CAPI v1.6.3=>v1.6.4

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2024
@adilGhaffarDev adilGhaffarDev marked this pull request as draft April 17, 2024 09:41
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2024
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2024
@adilGhaffarDev adilGhaffarDev marked this pull request as ready for review April 17, 2024 09:45
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2024
@adilGhaffarDev
controller-runtime uplift v0.16.3-v0.16.5
46a64ce 
Signed-off-by: adil ghaffar <muhammad.adil.ghaffar@est.tech>
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2024
tuminoid
tuminoid reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also bumps CAPI in /test, please add that to description.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@adilGhaffarDev adilGhaffarDev changed the title 🌱 controller-runtime uplift v0.16.3-v0.16.5 🌱 Bump controller-runtime v0.16.3=>v0.16.5 and CAPI v1.6.3=>v1.6.4 Apr 17, 2024
@adilGhaffarDev adilGhaffarDev changed the title 🌱 Bump controller-runtime v0.16.3=>v0.16.5 and CAPI v1.6.3=>v1.6.4 🌱 Bump controller-runtime and CAPI Apr 17, 2024
@adilGhaffarDev
Copy link
Member Author

Also bumps CAPI in /test, please add that to description.

done

@kashifest kashifest changed the title 🌱 Bump controller-runtime and CAPI 🌱 Bump controller-runtime to v0.16.3 and CAPI to v1.6.4 Apr 17, 2024
kashifest
kashifest reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@adilGhaffarDev
Copy link
Member Author

/test-centos-e2e-integration-main
/test metal3-bmo-e2e-test-pull

@adilGhaffarDev
Copy link
Member Author

/test-centos-e2e-integration-main

@metal3-io-bot metal3-io-bot merged commit 2c6d9b7 into metal3-io:main Apr 17, 2024
41 checks passed
@metal3-io-bot metal3-io-bot deleted the minor-fix.adil branch April 17, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest kashifest left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adilGhaffarDev @metal3-io-bot @tuminoid @kashifest