Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Remove hardware profile from the print columns #1713

Merged
merged 1 commit into from
May 22, 2024

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented May 2, 2024

The feature is deprecated and will not be present in API v1beta1.
It does not make sense to show it in the wide CLI output.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur
Copy link
Member Author

dtantsur commented May 2, 2024

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2024
@dtantsur
Copy link
Member Author

dtantsur commented May 2, 2024

/retitle ⚠️ Remove hardware profile from the print columns

@metal3-io-bot metal3-io-bot changed the title Remove hardware profile from the print columns ⚠️ Remove hardware profile from the print columns May 2, 2024
@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@dtantsur
Copy link
Member Author

dtantsur commented May 2, 2024

/test metal3-bmo-e2e-test-pull
/test metal3-centos-e2e-integration-test-main

@dtantsur
Copy link
Member Author

dtantsur commented May 2, 2024

/test metal3-centos-e2e-integration-test-main

@tuminoid
Copy link
Member

tuminoid commented May 6, 2024

Can you put a proper description to the PR?

@dtantsur
Copy link
Member Author

dtantsur commented May 6, 2024

@tuminoid done

@tuminoid
Copy link
Member

/cc @lentzi90 @Rozzii @kashifest

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@metal3-io-bot metal3-io-bot merged commit c425789 into metal3-io:main May 22, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants