Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 refactor TLS config #1737

Merged
merged 1 commit into from
May 22, 2024

Conversation

tuminoid
Copy link
Member

TLS config code causes security linters to report false positive about TLS versions that can be configured.

This is porting over CAPO PR 2037.

TLS config code causes security linters to report false positive
about TLS versions that can be configured.

This is porting over CAPO PR 2037.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2024
@tuminoid
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

@tuminoid
Copy link
Member Author

/cc @kashifest @lentzi90 @dtantsur

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@tuminoid
Copy link
Member Author

/cc @Rozzii

@metal3-io-bot metal3-io-bot requested a review from Rozzii May 22, 2024 04:56
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@tuminoid
Copy link
Member Author

/retest

@tuminoid
Copy link
Member Author

/test generate gomod manifestlint unit
Tide is stuck

@metal3-io-bot metal3-io-bot merged commit c8cf1c4 into metal3-io:main May 22, 2024
16 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/refactor-tls-config branch May 22, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants