Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Adapt ci-e2e.sh for github workflow #1768

Closed
wants to merge 1 commit into from
Closed

🌱 Adapt ci-e2e.sh for github workflow #1768

wants to merge 1 commit into from

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Jun 5, 2024

What this PR does / why we need it:

This is a backport of changes done on main to make the e2e tests work on github workflows.
See #1728

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@lentzi90
Adapt ci-e2e.sh for github workflow
9f703e2 
This is a backport of changes done on main to make the e2e tests work on
github workflows.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lentzi90. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 5, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Jun 5, 2024

/cherry-pick release-0.5

@metal3-io-bot
Copy link
Contributor

@lentzi90: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lentzi90
Copy link
Member Author

lentzi90 commented Jun 5, 2024

/test metal3-bmo-e2e-test-pull

1 similar comment
@lentzi90
Copy link
Member Author

lentzi90 commented Jun 5, 2024

/test metal3-bmo-e2e-test-pull

@lentzi90
Copy link
Member Author

lentzi90 commented Jun 5, 2024

/hold
Let's see if we can cherry pick #1728 as a whole instead

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Jun 5, 2024

Replaced by #1769

@lentzi90 lentzi90 closed this Jun 5, 2024
@lentzi90 lentzi90 deleted the lentzi90/github-workflow-fix branch June 5, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Awaiting requested review from Rozzii

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lentzi90 @metal3-io-bot