Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix htpasswd generation in run_local_ironic.sh #1780

Merged
merged 1 commit into from
Jun 11, 2024
Merged

🐛 fix htpasswd generation in run_local_ironic.sh #1780

merged 1 commit into from
Jun 11, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jun 11, 2024 •
edited
Loading

It tries to execute the htpasswd string instead of redirecting it to file, thanks to extra subshell "$( ... )". Removed.

https://jenkins.nordix.org/blue/organizations/jenkins/metal3-dev-env-integration-test-ubuntu-main/detail/metal3-dev-env-integration-test-ubuntu-main/21/pipeline/

[2024-06-11T06:57:16.454Z] /home/metal3ci/go/src/github.com/metal3-io/baremetal-operator/tools/run_local_ironic.sh: line 176: YC76iK4sKn42:$2y$05$DPXYNTSnqeIG9RGFEREgd.we9gOOlFbnsKQPnAPlF2lSzzCotRM6C: command not found
[2024-06-11T06:57:16.454Z] make: *** [Makefile:12: launch_mgmt_cluster] Error 127

@tuminoid
fix htpasswd generation in run_local_ironic.sh
4017a8c 
It tries to execute the htpasswd string instead of redirecting it to
file, thanks to extra subshell "$( ... )". Removed.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 11, 2024
@tuminoid
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@tuminoid: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test

The following commands are available to trigger optional jobs:

  • /test metal3-bmo-e2e-test-optional-pull
  • /test metal3-bmo-e2e-test-pull
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • shellcheck

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@tuminoid
Copy link
Member Author

We can see it passed the problematic stage: https://jenkins.nordix.org/blue/organizations/jenkins/metal3-dev-env-integration-test-ubuntu-main/detail/metal3-dev-env-integration-test-ubuntu-main/22/pipeline/

/cc @kashifest @Rozzii

@tuminoid tuminoid mentioned this pull request Jun 11, 2024
Closed
@Rozzii
Copy link
Member

Rozzii commented Jun 11, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
@MahnoorAsghar
Copy link
Contributor

Thanks for the fix, lgtm

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@metal3-io-bot metal3-io-bot merged commit 8cf3e7e into metal3-io:main Jun 11, 2024
29 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/fix-local-ironic branch June 11, 2024 09:46
openstack-mirroring pushed a commit to openstack/ironic that referenced this pull request Jun 12, 2024
@elfosardo
Makes metal3 integration job vote again
aaf62c6 
Fix in BMO at
metal3-io/baremetal-operator#1780

Change-Id: I3785441f4f327dcec113276803becd938fe87b9c
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Jun 12, 2024
@openstack-gerrit
Update git submodules
144c2c8 
* Update ironic from branch 'master'
  to 6590f10f03c1e084ac258252cd450073cfb53644
  - Merge "Makes metal3 integration job vote again"
  - Makes metal3 integration job vote again
    
    Fix in BMO at
    metal3-io/baremetal-operator#1780
    
    Change-Id: I3785441f4f327dcec113276803becd938fe87b9c
@tuminoid tuminoid mentioned this pull request Jun 14, 2024
Closed
derekhiggins pushed a commit to derekhiggins/ironic that referenced this pull request Jul 10, 2024
@elfosardo @derekhiggins
Makes metal3 integration job vote again
94a78cf 
Fix in BMO at
metal3-io/baremetal-operator#1780

Change-Id: I3785441f4f327dcec113276803becd938fe87b9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rj1k s3rj1k Awaiting requested review from s3rj1k

@zhouhao3 zhouhao3 Awaiting requested review from zhouhao3

@kashifest kashifest Awaiting requested review from kashifest

@Rozzii Rozzii Awaiting requested review from Rozzii

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @metal3-io-bot @Rozzii @MahnoorAsghar @kashifest