Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump golang to 1.22 in release 0.6 #1824

Merged
merged 1 commit into from
Aug 12, 2024
Merged

🌱 Bump golang to 1.22 in release 0.6 #1824

merged 1 commit into from
Aug 12, 2024
+13 −13

Conversation

NymanRobin
Copy link
Member

This is done since golang 1.21 is deprecating in August 2024

Fixes #1803

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2024
@NymanRobin NymanRobin mentioned this pull request Jul 25, 2024
Merged
@NymanRobin
Copy link
Member Author

Here is the corresponding project-infra change: metal3-io/project-infra#823
That will be needed before this will pass the tests

@NymanRobin
Copy link
Member Author

/retest

dtantsur
dtantsur previously requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still is my regular request to avoid unnecessary changes to go.mod, especially on stable branches.

go.mod Outdated Show resolved Hide resolved
@NymanRobin
Bump golang to 1.22 in release 0.6
ea763ad 
Since golang 1.21 is deprecating in August 2024

Signed-off-by: NymanRobin <robin.nyman@est.tech>
@NymanRobin NymanRobin force-pushed the bump-golang-to-1.22-in-release-0.6 branch from 826dcda to ea763ad Compare July 30, 2024 06:56
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2024
@NymanRobin
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@NymanRobin: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-release-1-7
  • /test metal3-centos-e2e-feature-test-release-1-7-features
  • /test metal3-centos-e2e-feature-test-release-1-7-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-7-remediation
  • /test metal3-centos-e2e-integration-test-release-1-7
  • /test metal3-dev-env-integration-test-centos-release-1-7
  • /test metal3-dev-env-integration-test-ubuntu-release-1-7
  • /test metal3-e2e-1-26-1-27-upgrade-test-release-1-7
  • /test metal3-e2e-1-27-1-28-upgrade-test-release-1-7
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-7
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-7
  • /test metal3-ubuntu-e2e-basic-test-release-1-7
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-remediation
  • /test metal3-ubuntu-e2e-integration-test-release-1-7

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • shellcheck
  • test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@NymanRobin
Copy link
Member Author

/test all

@NymanRobin NymanRobin mentioned this pull request Aug 1, 2024
Merged
@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024
@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024
@tuminoid
Copy link
Member

tuminoid commented Aug 6, 2024

@dtantsur I think your concern was fixed, can you remove the "request changes" review, as it is blocking merging?

@tuminoid
Copy link
Member

tuminoid commented Aug 6, 2024 •
edited
Loading

/hold
GH side blocking is messing tide up, so holding to make tide unblock the merge queue for other PRs.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2024
@tuminoid
Copy link
Member

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2024
@metal3-io-bot metal3-io-bot merged commit b7ccd94 into metal3-io:release-0.6 Aug 12, 2024
19 checks passed
@metal3-io-bot metal3-io-bot deleted the bump-golang-to-1.22-in-release-0.6 branch August 12, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@mquhuy mquhuy Awaiting requested review from mquhuy

@zhouhao3 zhouhao3 Awaiting requested review from zhouhao3

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NymanRobin @metal3-io-bot @elfosardo @kashifest @tuminoid @dtantsur