🐛 Fix HFC Status #1825
Merged
🐛 Fix HFC Status #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/S
dtantsur
reviewed
Jul 29, 2024
dtantsur
reviewed
Jul 29, 2024
This commit fixes the following cases for HFC: - Status Components Information using the newer information that ironic contains. - Clear the Status Updates in case of a failed fiirmware update, so it can retry. Also change the condition as a follow-up to baremetal-operator#1793 Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
iurygregory
force-pushed
the
fix-hfc-component-info
branch
from
b2fd7e4
to
a62a169
Compare
dtantsur
reviewed
Jul 30, 2024
| // Check if there are Updates in the Spec that are different than the Status | ||
| if meta.IsStatusConditionTrue(hfc.Status.Conditions, string(metal3api.HostFirmwareComponentsChangeDetected)) { | ||
| // Check if the condition matches the current Generation to know if the data is not out of date. | ||
| if readyCond := meta.FindStatusCondition(hfc.Status.Conditions, string(metal3api.HostFirmwareComponentsChangeDetected)); readyCond != nil && readyCond.Status == metav1.ConditionTrue && readyCond.ObservedGeneration == hfc.Generation { | ||
| if meta.IsStatusConditionTrue(hfc.Status.Conditions, string(metal3api.HostFirmwareComponentsValid)) { |
There was a problem hiding this comment.
I assume we don't need the same generation check here because all conditions are updated together, right?
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the following cases for HFC:
Also change the condition as a follow-up to baremetal-operator#1793
What this PR does / why we need it: metal3-io/metal3-docs#364,