🌱 Uplift controller-runtime v0.17.6 #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/M
adilGhaffarDev
changed the title
|
/hold |
metal3-io-bot
added
the
do-not-merge/hold
metal3-io-bot
added
the
do-not-merge/work-in-progress
tuminoid
reviewed
Aug 14, 2024
adilGhaffarDev
force-pushed
the
uplift-cr-17.5/adil
branch
from
7cf4efb
to
e7df2dd
Compare
metal3-io-bot
added
the
needs-rebase
Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
adilGhaffarDev
force-pushed
the
uplift-cr-17.5/adil
branch
from
e7df2dd
to
dff8807
Compare
metal3-io-bot
removed
the
needs-rebase
adilGhaffarDev
changed the title
metal3-io-bot
removed
the
do-not-merge/work-in-progress
adilGhaffarDev
changed the title
|
/unhold |
metal3-io-bot
removed
the
do-not-merge/hold
tuminoid
reviewed
Aug 14, 2024
|
cc @kashifest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Uplift controller-runtime v0.17.6. This PR is also fixing one of the Unit tests which was failing because of the wrong schema.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1677