Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Pin ginkgo cli to test/go.mod ginkgo package #1947

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Pin ginkgo cli to test/go.mod ginkgo package #1947

wants to merge 1 commit into from

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Sep 11, 2024

Ginkgo CLI version is once again mismatches with the packaged version.

To prevent this from happening again, this PR pins the Ginkgo CLI version to whatever version it is in test/go.mod.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Sep 12, 2024

/retest

@mquhuy
Copy link
Member Author

mquhuy commented Sep 12, 2024

/cc @kashifest @tuminoid @Rozzii

Rozzii
Rozzii reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 16, 2024
@mquhuy mquhuy force-pushed the mquhuy/pin-ginkgo-cli-to-package-version branch from 76cb9d6 to 9908548 Compare September 17, 2024 07:22
@metal3-io-bot metal3-io-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 17, 2024
@mquhuy
Pin ginkgo cli to test/go.mod ginkgo package
bbcd4dd 
Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/pin-ginkgo-cli-to-package-version branch from 9908548 to bbcd4dd Compare September 17, 2024 07:24
tuminoid
tuminoid reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Rozzii left review comments

@s3rj1k s3rj1k Awaiting requested review from s3rj1k

@zaneb zaneb Awaiting requested review from zaneb

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @metal3-io-bot @tuminoid @Rozzii