Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump controller runtime to v0.18.5 and CAPI to v1.8.3 #1967

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

kashifest
Copy link
Member

@kashifest kashifest commented Sep 18, 2024

Bumps controller runtime to v0.18.5 and cluster-api to v1.8.3
Fixes #1964

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 18, 2024
@kashifest kashifest changed the title 🌱 Bump controller runtime to v0.18.5 anc cluster-api to v1.8.3 🌱 Bump controller runtime to v0.18.5 and cluster-api to v1.8.3 Sep 18, 2024
@kashifest
Copy link
Member Author

/retest

@kashifest kashifest changed the title 🌱 Bump controller runtime to v0.18.5 and cluster-api to v1.8.3 🌱 Bump controller runtime to v0.18.5 and CAIP to v1.8.3 Sep 18, 2024
@kashifest
Copy link
Member Author

kashifest commented Sep 18, 2024

/cc @dtantsur

@mquhuy
Copy link
Member

mquhuy commented Sep 19, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@kashifest kashifest changed the title 🌱 Bump controller runtime to v0.18.5 and CAIP to v1.8.3 🌱 Bump controller runtime to v0.18.5 and CAPI to v1.8.3 Sep 20, 2024
apis/go.mod Outdated Show resolved Hide resolved
apis/go.mod Outdated Show resolved Hide resolved
apis/go.mod Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
test/go.mod Outdated Show resolved Hide resolved
test/go.mod Show resolved Hide resolved
Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@kashifest
Copy link
Member Author

/cc @dtantsur @honza @zaneb

@kashifest
Copy link
Member Author

Can I get an approval here? Other PRs are waiting for this one to go in @dtantsur @honza @zaneb

@zaneb
Copy link
Member

zaneb commented Oct 7, 2024

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@metal3-io-bot metal3-io-bot merged commit 4ba960b into metal3-io:main Oct 7, 2024
16 of 17 checks passed
@metal3-io-bot metal3-io-bot deleted the kashif/bump-go-modules branch October 7, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump CAPI to 1.8.x
5 participants