Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Added Error message when reconciling loop is triggered more than once #2083

Merged
merged 4 commits into from
Nov 25, 2024
Merged

🌱 Added Error message when reconciling loop is triggered more than once #2083

merged 4 commits into from
Nov 25, 2024

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #1792

/assign dtantsur

babugeet and others added 4 commits November 25, 2024 12:09
@babugeet
Added Error message when reconciling loop is triggered more than once…
2d03cf5 
… Signed-off-by: “babugeet <abhinandhbg@gmail.com>”

Signed-off-by: babugeet <97796199+babugeet@users.noreply.github.com>
@babugeet
fixed lint issues Signed-off-by: babugeet <abhinandhbg@gmail.com>
5553c72 
Signed-off-by: babugeet <97796199+babugeet@users.noreply.github.com>
@babugeet
fixed review comments
c0813d9 
Signed-off-by: babugeet <97796199+babugeet@users.noreply.github.com>
@babugeet
fixed review comments
16e7624 
Signed-off-by: babugeet <97796199+babugeet@users.noreply.github.com>
@metal3-io-bot metal3-io-bot mentioned this pull request Nov 25, 2024
Merged
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 25, 2024
@tuminoid
Copy link
Member

/retitle 🌱 Added Error message when reconciling loop is triggered more than once

@metal3-io-bot metal3-io-bot changed the title [release-0.8] 🌱 Added Error message when reconciling loop is triggered more than once 🌱 Added Error message when reconciling loop is triggered more than once Nov 25, 2024
@tuminoid
Copy link
Member

These should've been squashed at the original PR, now we ended up with DCO issues in cherry-pick PR.

@tuminoid
Copy link
Member

These should've been squashed at the original PR, now we ended up with DCO issues in cherry-pick PR.

Overrode DCO, as all commits are signed off, but third commit is double signed-off incorrectly, so DCO check took offense on that.

tuminoid
tuminoid reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@metal3-io-bot metal3-io-bot merged commit 1098d95 into metal3-io:release-0.8 Nov 25, 2024
27 checks passed
@dtantsur dtantsur mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@dtantsur dtantsur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@metal3-io-bot @tuminoid @dtantsur @babugeet