-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Issue template for preparing new minor release #1748
base: main
Are you sure you want to change the base?
Conversation
That is the great addition. Thanks @adilGhaffarDev |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
|
||
* [ ] Add/edit JJBs to acommodate new build jobs and PR jobs for new release branches. [Prior art](https://gerrit.nordix.org/c/infra/cicd/+/20875) | ||
* [ ] Add Prow jobs for new release branches in Project-infra repo [Prior art](https://github.com/metal3-io/project-infra/pull/697) | ||
* [ ] Prepare dev-env to acommodate release-1.7 related changes and configurations [Prior art](https://github.com/metal3-io/metal3-dev-env/pull/1381) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not put past release versions in the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed versions, can you check again
d8e415b
to
b455689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NItting, but also questioning should this be somewhere else than CAPM3?
* [ ] Update Metal3 book. [Prior art](https://github.com/metal3-io/metal3-docs/pull/413) | ||
* [ ] Release Ironic, also check new image is created in quay. [Prior art](https://github.com/metal3-io/ironic-image/tags) | ||
* [ ] Pin Ironic in BMO and release BMO, also check new image is created in quay. [Prior art](https://github.com/metal3-io/baremetal-operator/pull/1679) | ||
* [ ] Release IPAM (Branch out, add branch protection and required tests, also check new image is created in quay). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were documenting IPAM/BMO/Ironic releasing in CAPM3 repo, shouldn't we have this tracking issue in more generic repo, like docs or dev-env or community? Most of these steps do not related to CAPM3 after all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what is the best place for this. If docs seems like a better place I can add it there. I added it here because the CAPM3 minor release is most of the time dependent on these releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CAPM template should be about things done in CAPM3, similar to releasing.md is repo specific. Then in metal3-docs there is one that covers the common/extra steps. IMO these issue templates should be the same.
@adilGhaffarDev Let's make this template get merged. This would be great to make release process smoother. |
b455689
to
c8a853a
Compare
addressed the comments and also rearranged some tasks. Let me know if anything is missed. |
Signed-off-by: adil ghaffar <muhammad.adil.ghaffar@est.tech>
c8a853a
to
1193fd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good after @tuminoid review.. Do we remove the hold? Feel free to remove it.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
* [ ] Uplift CAPI to latest minor in CAPM3, also check migration guide: [Migration guide for providers](https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations). [Prior art CAPM3](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1604). | ||
IMPORTANT: Always read migration guide and make sure to do the changes accordingly in CAPM3 and IPAM. | ||
* [x] Uplift k8s to 1.31 in CAPM3 and metal3-dev-env repo. [Prior art metal3-dev-env](https://github.com/metal3-io/metal3-dev-env/pull/1389), [Prior art CAPM3](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1622) | ||
* [x] Uplift k8s to 1.31 in image building pipeline. [Prior art jjb](https://gerrit.nordix.org/c/infra/cicd/+/22205) [Prior art pipeline](https://github.com/metal3-io/project-infra/pull/836) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 uplifts still refer to specific k8s versions, also remove the ticks.
What this PR does / why we need it:
This PR is adding an issue template for preparing a new minor release. It will make it easier to create tracking issue.