⚠️ Bump CAPI to v1.5.0, controller-runtime to v0.15.0 and controller-tools to v0.12.1 #280

Sunnatillo · 2023-07-13T20:27:53Z

This PR:

Bumps CAPI to v1.5.0 and CR v0.15.0.
Adds finalizers to objects with deletionTimeStamp due to changes in CR v0.15.0
Removes deprecated linters(varcheck, structcheck, deadcode deprecated since golangci-lint v1.49.0)
Adds WithStatusSubresource to fake client, due to status handling changes in CR v0.15.0.

Sunnatillo · 2023-07-14T21:07:08Z

/test gomod

Sunnatillo · 2023-07-24T11:14:28Z

/retest

kashifest · 2023-07-24T11:59:55Z

ipam/ippool_manager_test.go

-			},
-			expectedAllocations:   map[string]ipamv1.IPAddressStr{},
-			expectedNbAllocations: 0,
-		}),


what is this change related to?

Due to CR v0.15.0 changes, fake client will panic if the object is initialized with deleteionTimestamp without Finalizer,

kashifest · 2023-07-24T12:00:12Z

ipam/ippool_manager_test.go

+							Name:      "abcpref-192-168-1-11",
+							Namespace: "myns",
+						},
+					},


When IpAddress created, it will update ipClaimStatus firtst and then will proceed with ip address creation. Here somehow we did not include status in IpClaim which is causing an error in current testcase. Not sure how it was passing before.

Interesting, it shouldn't have passed if thats the case.

It was actually due to status handling changes in CR v0,15.0. Fixed now

metal3-io-bot · 2023-07-26T13:30:54Z

@Sunnatillo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
golangci-lint	`466b2b2`	link	true	`/test golangci-lint`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kashifest

You need to bump controller-runtime in api/go.mod as well to v0.15.0

Sunnatillo · 2023-07-26T15:36:14Z

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

Sunnatillo · 2023-07-26T16:58:21Z

/test-ubuntu-integration-main

kashifest

Very good job. Few small nits inline. This PR is in pretty good shape.

kashifest · 2023-07-27T05:59:42Z

.golangci.yaml

    - stylecheck
    - thelper
    - typecheck
    - unconvert
    - unused
-    - varcheck


Can you please add some explanation about removing these checks in the PR description?

kashifest · 2023-07-27T06:05:24Z

config/crd/bases/ipam.metal3.io_ipaddresses.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
  annotations:
-    controller-gen.kubebuilder.io/version: v0.11.4
+    controller-gen.kubebuilder.io/version: v0.12.1


CAPI is sitting currently on v0.12.0. Its fine for now since its a patch version but lets wait for CAPI to bump this for future bumps.

kashifest · 2023-07-27T06:12:41Z

hack/tools/go.mod

@@ -4,8 +4,8 @@ go 1.20

 require (
 	github.com/jteeuwen/go-bindata v3.0.7+incompatible
-	k8s.io/code-generator v0.26.1
-	sigs.k8s.io/controller-tools v0.11.4
+	k8s.io/code-generator v0.27.1


you have bumped other k8s packages to v0.27.2 in root go.mod and api/go.mod. Can you check if we can do the same for this package.

kashifest · 2023-07-27T06:13:40Z

ipam/ippool_manager_test.go

+							Name:      "abcpref-192-168-1-11",
+							Namespace: "myns",
+						},
+					},


Interesting, it shouldn't have passed if thats the case.

kashifest · 2023-07-27T07:19:25Z

/retitle Bump CAPI to v1.5.0, controller-runtime to v0.15.0 and controller-tools to v0.12.1

Sunnatillo · 2023-07-27T15:39:33Z

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

Sunnatillo · 2023-07-28T07:14:48Z

/cc @smoshiur1237

Sunnatillo · 2023-07-28T10:07:30Z

/hold
need check the changes

smoshiur1237 · 2023-07-28T10:10:49Z

ipam/ippool_manager_test.go

@@ -416,7 +422,7 @@ var _ = Describe("IPPool manager", func() {
 					},
 					Status: ipamv1.IPClaimStatus{
 						Address: &corev1.ObjectReference{
-							Name:      "abcpref-192-168-1-12",
+							Name:      "abcpref-192-168-1-10",


Would you please check if this is correct? I think it doesn't need this change.

yes, thank you for noticing. Fixed it.

remove deprecated linters(varcheck, structcheck, deadcode)

Sunnatillo · 2023-07-28T13:22:47Z

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

Sunnatillo · 2023-07-28T13:24:38Z

/unhold

smoshiur1237

Thanks for the fix.
/lgtm

metal3-io-bot · 2023-08-01T07:42:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

furkatgofurov7 · 2023-08-17T18:54:18Z

/retitle ⚠️ Bump CAPI to v1.5.0, controller-runtime to v0.15.0 and controller-tools to v0.12.1

metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 13, 2023

Sunnatillo force-pushed the bump-capi-v1.5.0-beta.1/sunnat branch 3 times, most recently from 7469130 to f1374fe Compare July 14, 2023 15:12

kashifest reviewed Jul 24, 2023

View reviewed changes

Sunnatillo force-pushed the bump-capi-v1.5.0-beta.1/sunnat branch from f1374fe to 466b2b2 Compare July 25, 2023 08:37

metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 25, 2023

Sunnatillo force-pushed the bump-capi-v1.5.0-beta.1/sunnat branch 3 times, most recently from 36acb9a to a007085 Compare July 26, 2023 13:27

Sunnatillo changed the title ~~WIP: Bump capi v1.5.0-beta.1 and golang version to v1.20~~ WIP: Bump capi v1.5.0 Jul 26, 2023

kashifest requested changes Jul 26, 2023

View reviewed changes

Sunnatillo force-pushed the bump-capi-v1.5.0-beta.1/sunnat branch from a007085 to 75c0613 Compare July 26, 2023 15:18

Sunnatillo changed the title ~~WIP: Bump capi v1.5.0~~ Bump capi v1.5.0 Jul 26, 2023

metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2023

Sunnatillo force-pushed the bump-capi-v1.5.0-beta.1/sunnat branch from 75c0613 to fd4fc3a Compare July 26, 2023 15:31

kashifest reviewed Jul 27, 2023

View reviewed changes

metal3-io-bot changed the title ~~Bump capi v1.5.0~~ Bump CAPI to v1.5.0, controller-runtime to v0.15.0 and controller-tools to v0.12.1 Jul 27, 2023

Sunnatillo force-pushed the bump-capi-v1.5.0-beta.1/sunnat branch from fd4fc3a to c81b271 Compare July 27, 2023 15:33

kashifest previously approved these changes Jul 27, 2023

View reviewed changes

metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2023

metal3-io-bot requested a review from smoshiur1237 July 28, 2023 07:14

metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023

smoshiur1237 reviewed Jul 28, 2023

View reviewed changes

Bump capi v1.5.0 and CR v0.15.0

cbaa4b4

remove deprecated linters(varcheck, structcheck, deadcode)

Sunnatillo dismissed kashifest’s stale review via cbaa4b4 July 28, 2023 13:21

Sunnatillo force-pushed the bump-capi-v1.5.0-beta.1/sunnat branch from c81b271 to cbaa4b4 Compare July 28, 2023 13:21

metal3-io-bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023

metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023

smoshiur1237 reviewed Jul 31, 2023

View reviewed changes

metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023

kashifest approved these changes Aug 1, 2023

View reviewed changes

metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023

metal3-io-bot merged commit 623678c into metal3-io:main Aug 1, 2023
2 checks passed

Sunnatillo deleted the bump-capi-v1.5.0-beta.1/sunnat branch August 15, 2023 11:50

Sunnatillo mentioned this pull request Aug 17, 2023

CAPI v1.5.0-beta.0 has been released and is ready for testing #279

Closed

furkatgofurov7 changed the title ~~Bump CAPI to v1.5.0, controller-runtime to v0.15.0 and controller-tools to v0.12.1~~ ⚠️ Bump CAPI to v1.5.0, controller-runtime to v0.15.0 and controller-tools to v0.12.1 Aug 17, 2023

Sunnatillo mentioned this pull request Aug 28, 2023

Bump CAPI to v1.5.0 #303

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⚠️ Bump CAPI to v1.5.0, controller-runtime to v0.15.0 and controller-tools to v0.12.1 #280

⚠️ Bump CAPI to v1.5.0, controller-runtime to v0.15.0 and controller-tools to v0.12.1 #280

Sunnatillo commented Jul 13, 2023 •

edited

Loading

Sunnatillo commented Jul 14, 2023

Sunnatillo commented Jul 24, 2023

kashifest Jul 24, 2023

Sunnatillo Jul 26, 2023 •

edited

Loading

kashifest Jul 24, 2023

Sunnatillo Jul 26, 2023 •

edited

Loading

kashifest Jul 27, 2023

Sunnatillo Jul 27, 2023

metal3-io-bot commented Jul 26, 2023 •

edited

Loading

kashifest left a comment

Sunnatillo commented Jul 26, 2023

Sunnatillo commented Jul 26, 2023

kashifest left a comment

kashifest Jul 27, 2023

kashifest Jul 27, 2023

kashifest Jul 27, 2023

kashifest Jul 27, 2023

kashifest commented Jul 27, 2023

Sunnatillo commented Jul 27, 2023

Sunnatillo commented Jul 28, 2023

Sunnatillo commented Jul 28, 2023 •

edited

Loading

smoshiur1237 Jul 28, 2023

Sunnatillo Jul 28, 2023

Sunnatillo commented Jul 28, 2023

Sunnatillo commented Jul 28, 2023

smoshiur1237 left a comment

metal3-io-bot commented Aug 1, 2023

furkatgofurov7 commented Aug 17, 2023

⚠️ Bump CAPI to v1.5.0, controller-runtime to v0.15.0 and controller-tools to v0.12.1 #280

⚠️ Bump CAPI to v1.5.0, controller-runtime to v0.15.0 and controller-tools to v0.12.1 #280

Conversation

Sunnatillo commented Jul 13, 2023 • edited Loading

Sunnatillo commented Jul 14, 2023

Sunnatillo commented Jul 24, 2023

Choose a reason for hiding this comment

Sunnatillo Jul 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sunnatillo Jul 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metal3-io-bot commented Jul 26, 2023 • edited Loading

kashifest left a comment

Choose a reason for hiding this comment

Sunnatillo commented Jul 26, 2023

Sunnatillo commented Jul 26, 2023

kashifest left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kashifest commented Jul 27, 2023

Sunnatillo commented Jul 27, 2023

Sunnatillo commented Jul 28, 2023

Sunnatillo commented Jul 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sunnatillo commented Jul 28, 2023

Sunnatillo commented Jul 28, 2023

smoshiur1237 left a comment

Choose a reason for hiding this comment

metal3-io-bot commented Aug 1, 2023

furkatgofurov7 commented Aug 17, 2023

Sunnatillo commented Jul 13, 2023 •

edited

Loading

Sunnatillo Jul 26, 2023 •

edited

Loading

Sunnatillo Jul 26, 2023 •

edited

Loading

metal3-io-bot commented Jul 26, 2023 •

edited

Loading

Sunnatillo commented Jul 28, 2023 •

edited

Loading