Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirrord-agent can leave leftover iptables records #955

Closed
eyalb181 opened this issue Jan 17, 2023 · 0 comments
Closed

mirrord-agent can leave leftover iptables records #955

eyalb181 opened this issue Jan 17, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@eyalb181
Copy link
Member

Bug Description

Not sure when this happens, but either way we need to add a more robust cleanup mechanism:
When an agent is started, it forks:

  • The forked process does the actual agent logic
  • The parent process waits for the forked process to exit, and when it does, ensures that it hasn't left any records in iptables

Steps to Reproduce

N/A

Backtrace

No response

Relevant Logs

No response

Your operating system and version

N/A

Local process

N/A

Local process version

No response

Additional Info

No response
@eyalb181 eyalb181 added the bug Something isn't working label Jan 17, 2023
@DmitryDodzin DmitryDodzin mentioned this issue Jan 23, 2023
Closed
bors bot pushed a commit that referenced this issue Jan 23, 2023
@DmitryDodzin
Process Level Guard for IPTables (#978)
d716e64 
closes #955
@bors bors bot closed this as completed in eaadde4 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Process Level Guard for IPTables DmitryDodzin/mirrord
1 participant
@eyalb181