Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unix stream sockets #1167

Merged
merged 45 commits into from
Mar 21, 2023
Merged

Support unix stream sockets #1167

merged 45 commits into from
Mar 21, 2023

Conversation

t4lz
Copy link
Member

@t4lz t4lz commented Mar 7, 2023 •
edited
Loading

#1105

TODO (or open issue):

  • Test with a socket that is not on the list and verify that the connection happens locally (or just test with the same setup as the basic test but without the config and check that the connection fails).

@t4lz t4lz force-pushed the unix-sockets branch 8 times, most recently from e212c15 to 5e22bde Compare March 13, 2023 12:08
eyalb181
eyalb181 reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@eyalb181 eyalb181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started going over the code, a few superficial comments

mirrord/protocol/src/outgoing.rs Show resolved Hide resolved
mirrord/config/src/outgoing.rs Outdated Show resolved Hide resolved
mirrord/config/src/outgoing/unix.rs Outdated Show resolved Hide resolved
mirrord/config/src/outgoing/unix.rs Outdated Show resolved Hide resolved
mirrord/layer/src/outgoing/tcp.rs Outdated Show resolved Hide resolved
mirrord/layer/src/outgoing/tcp.rs Outdated Show resolved Hide resolved
mirrord/layer/src/outgoing/udp.rs Outdated Show resolved Hide resolved
@t4lz t4lz force-pushed the unix-sockets branch 2 times, most recently from dafc408 to 1aa4746 Compare March 14, 2023 16:19
eyalb181
eyalb181 reviewed Mar 14, 2023
View reviewed changes
mirrord/protocol/src/outgoing.rs Show resolved Hide resolved
mirrord/layer/src/outgoing/tcp.rs Outdated Show resolved Hide resolved
mirrord/layer/src/socket/ops.rs Outdated Show resolved Hide resolved
mirrord/layer/src/socket/ops.rs Outdated Show resolved Hide resolved
@t4lz t4lz force-pushed the unix-sockets branch 6 times, most recently from f768f27 to 674ab17 Compare March 15, 2023 12:33
@t4lz t4lz changed the title Support unix tcp sockets Support unix stream sockets Mar 15, 2023
@t4lz t4lz force-pushed the unix-sockets branch 2 times, most recently from bce1545 to 9dadb71 Compare March 15, 2023 18:23
@t4lz t4lz marked this pull request as ready for review March 16, 2023 13:04
eyalb181
eyalb181 approved these changes Mar 16, 2023
View reviewed changes
mirrord/protocol/src/outgoing.rs Outdated Show resolved Hide resolved
mirrord/protocol/src/outgoing.rs Outdated Show resolved Hide resolved
mirrord/layer/src/outgoing/tcp.rs Outdated Show resolved Hide resolved
mirrord/layer/src/socket/ops.rs Outdated Show resolved Hide resolved
mirrord/layer/src/socket/ops.rs Show resolved Hide resolved
@t4lz
Copy link
Member Author

t4lz commented Mar 17, 2023

metalbear-co/test-images#15 needs to be merged first, and the test updated here, before this PR could be merged.

@t4lz t4lz enabled auto-merge March 21, 2023 09:47
@t4lz t4lz added this pull request to the merge queue Mar 21, 2023
@t4lz t4lz merged commit 2ed23d3 into metalbear-co:main Mar 21, 2023
@t4lz t4lz deleted the unix-sockets branch March 21, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalb181 eyalb181 eyalb181 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t4lz @eyalb181