Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running emulated processes on m1 using mirrord #122

Conversation

aviramha
Copy link
Member

@aviramha aviramha commented Jun 7, 2022

This will download and use x64 binary when needed.

@aviramha aviramha requested a review from eyalb181 June 7, 2022 17:53
Copy link
Member

@meowjesty meowjesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

mirrord-cli/src/main.rs Outdated Show resolved Hide resolved
mirrord-cli/src/main.rs Outdated Show resolved Hide resolved
mirrord-cli/src/main.rs Outdated Show resolved Hide resolved
@aviramha aviramha merged commit bb75903 into metalbear-co:main Jun 8, 2022
@aviramha aviramha deleted the 114-incompatible-architecture-have-arm64-need-x86_64 branch June 8, 2022 16:52
@messense
Copy link
Contributor

I'd suggest build universal2 binaries instead, that way it will work on both Intel and Apple Silicon Macs automatically and when running in emulated mode on Apple Silicon it just works™️.

@aviramha
Copy link
Member Author

I'd suggest build universal2 binaries instead, that way it will work on both Intel and Apple Silicon Macs automatically and when running in emulated mode on Apple Silicon it just works™️.

That was me initial thought but couldn't get cargo to produce such binaries. Do you know how?

@messense
Copy link
Contributor

@aviramha Opened #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants