Override remote env #25 #134

meowjesty · 2022-06-09T19:42:26Z

Added an env variable for mirrord (MIRRORD_OVERRIDE_ENV) that enables overriding environment variables with the remote ones.

Closes #25

…ect string?

CHANGELOG.md

mirrord-agent/src/main.rs

mirrord-layer/src/lib.rs

mirrord-protocol/src/lib.rs

aviramha

Looking great, I left few comments more about design/naming ;)
Edit:
Please add coverage in the e2e

CHANGELOG.md

mirrord-agent/src/main.rs

mirrord-layer/src/config.rs

CHANGELOG.md

mirrord-layer/src/lib.rs

…of select arguments. Changed name for env vars request/response messages.

…lters out some keys by default, like PATH (user cant control these defaults).

aviramha

LGTM

aviramha

Seems to be ready once CI is working!

.vscode/launch.json

tests/src/utils.rs

mirrord-layer/src/lib.rs

…lude + exclude. Removed flag to enable/disable env vars, now controller by having values in the filters.

…st panic (wow what a phrase).

meowjesty added 8 commits June 7, 2022 17:19

(broken) Adding remote env var loading.

088b12f

Loading env vars from nginx.

bd3e6aa

Loading env vars from remote proc works, but it doesn't load the corr…

db0b599

…ect string?

Notes on how to proceed (nginx out).

5059cd0

Working override env vars.

f730120

Fix wrong pid value being used.

ed81e83

Merge branch 'main' into remote_env

c753eb3

Clean files.

6afc62d

meowjesty requested a review from aviramha June 9, 2022 19:42

meowjesty self-assigned this Jun 9, 2022

meowjesty added this to the MVP milestone Jun 9, 2022

Use correct imagePullPolicy.

9a0cf82

aviramha requested changes Jun 9, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

mirrord-agent/src/main.rs Show resolved Hide resolved

mirrord-layer/src/lib.rs Outdated Show resolved Hide resolved

meowjesty added 2 commits June 10, 2022 03:54

Simplify env vars handling. Make it select all then filter.

f7b4289

Merge branch 'main' into remote_env

c7ea70e

meowjesty requested review from aviramha and eyalb181 June 10, 2022 06:58

Fix launch.json env.

b7326af

eyalb181 reviewed Jun 10, 2022

View reviewed changes

mirrord-protocol/src/lib.rs Outdated Show resolved Hide resolved

meowjesty added 3 commits June 10, 2022 12:25

Remove unused rust features.

474dc45

Put env vars override behind an enabled bool flag.

86e6b8b

Add configuration for setting up override env vars + filter.

ddb5463

aviramha reviewed Jun 11, 2022

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

mirrord-agent/src/main.rs Show resolved Hide resolved

mirrord-agent/src/main.rs Outdated Show resolved Hide resolved

mirrord-agent/src/main.rs Show resolved Hide resolved

aviramha reviewed Jun 11, 2022

View reviewed changes

mirrord-layer/src/config.rs Outdated Show resolved Hide resolved

eyalb181 requested changes Jun 11, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

mirrord-layer/src/lib.rs Outdated Show resolved Hide resolved

mirrord-layer/src/lib.rs Outdated Show resolved Hide resolved

meowjesty added 5 commits June 12, 2022 03:16

Refactor some layer initialization functions to take config, instead …

78fcba4

…of select arguments. Changed name for env vars request/response messages.

Update changelog. Renamed env vars config. Env vars overriding now fi…

cf05535

…lters out some keys by default, like PATH (user cant control these defaults).

Fix comment.

2508945

Merge main.

59c2c67

local config.

32b6f02

Update branch.

8345dc4

aviramha approved these changes Jun 15, 2022

View reviewed changes

meowjesty added 8 commits June 15, 2022 14:24

Change mirrord to custom image for tests.

dc4af8d

Merge main branch.

b79c930

Add remote env vars test.

eba1c0d

Make test app crash on incorrect env vars.

46f3532

Ignore unrelated tests to make CI go faster.

40ecc16

Env vars now filter + select properly.

698cfc8

Fix include string.

6038f0f

Fix env vars test args.

de1524e

aviramha approved these changes Jun 18, 2022

View reviewed changes

.vscode/launch.json Outdated Show resolved Hide resolved

.vscode/launch.json Outdated Show resolved Hide resolved

tests/src/utils.rs Outdated Show resolved Hide resolved

eyalb181 requested changes Jun 18, 2022

View reviewed changes

mirrord-layer/src/lib.rs Outdated Show resolved Hide resolved

meowjesty added 15 commits June 20, 2022 14:14

Added more tests for remote_env. Don't allow user to specify both inc…

77a8923

…lude + exclude. Removed flag to enable/disable env vars, now controller by having values in the filters.

Merge main.

27b8972

Fix launch.json.

dd86154

Use proper test image.

95296ae

Build in latest nightly.

2cbb473

Fix remote_env tests using the wrong option.

620c315

Fix comments.

728d143

Support include * as an include all env vars.

05f641d

Log result of tests process.

e922cd0

Failure test should panic.

ae0aa66

Less clutter in console for remote env tests.

399f8a2

Debug why test that should panic (and panics), doesn't trigger the te…

0fbc3d0

…st panic (wow what a phrase).

Return exit code -1 if we have an env var selected.

9e18e27

Merge branch 'main' into remote_env

b8d1996

Fix test for panicking remote_env. Re-enable other tests.

d9a1fd7

eyalb181 approved these changes Jun 20, 2022

View reviewed changes

aviramha merged commit b18c253 into metalbear-co:main Jun 21, 2022

meowjesty deleted the remote_env branch September 8, 2022 17:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Override remote env #25 #134

Override remote env #25 #134

meowjesty commented Jun 9, 2022

aviramha left a comment •

edited

Loading

aviramha left a comment

aviramha left a comment

Override remote env #25 #134

Override remote env #25 #134

Conversation

meowjesty commented Jun 9, 2022

aviramha left a comment • edited Loading

Choose a reason for hiding this comment

aviramha left a comment

Choose a reason for hiding this comment

aviramha left a comment

Choose a reason for hiding this comment

aviramha left a comment •

edited

Loading