Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create macOS universal2 binaries #140

Merged
merged 1 commit into from
Jun 12, 2022
Merged

Create macOS universal2 binaries #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:

release_gh:
needs: [build_binaries, release_docker_image, release_vscode_ext]
runs-on: ubuntu-latest
runs-on: macos-latest
permissions:
packages: write
contents: write
Expand All @@ -131,9 +131,13 @@ jobs:
mv /tmp/artifacts/x86_64-apple-darwin/mirrord /tmp/release/mirrord_mac_x86_64
mv /tmp/artifacts/aarch64-apple-darwin/libmirrord_layer.dylib /tmp/release/libmirrord_layer_mac_aarch64.dylib
mv /tmp/artifacts/aarch64-apple-darwin/mirrord /tmp/release/mirrord_mac_aarch64

# create universal2 binaries for macOS
cd /tmp/release
lipo -create -output libmirrord_layer_mac.dylib libmirrord_layer_mac_x86_64.dylib libmirrord_layer_mac_aarch64.dylib
lipo -create -output mirrord_mac mirrord_mac_x86_64 mirrord_mac_aarch64
# Consider to add changelog generation..
- name: Release
uses: softprops/action-gh-release@v1
with:
files: /tmp/release/**