Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Change protocol + mirrord-layer to split messages into modu… #150

Merged
merged 10 commits into from
Jun 16, 2022

Conversation

aviramha
Copy link
Member

…les, so main module only handles general messages, passing down to the appropriate module for handling.

…les, so main module only handles general messages, passing down to the appropriate module for handling.
Copy link
Member

@meowjesty meowjesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see this building on top of the previous refactor.

Can't spot anything that I would ask for changes (at least not until I have to use this :P).

mirrord-agent/src/main.rs Show resolved Hide resolved
mirrord-agent/src/main.rs Show resolved Hide resolved
mirrord-agent/src/main.rs Show resolved Hide resolved
mirrord-layer/src/sockets.rs Show resolved Hide resolved
mirrord-protocol/src/lib.rs Outdated Show resolved Hide resolved
@aviramha aviramha merged commit f677ce2 into metalbear-co:main Jun 16, 2022
@aviramha aviramha deleted the more_refactoring branch June 16, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants