Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lutaml express liquid #169

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add lutaml express liquid #169

wants to merge 8 commits into from

Conversation

kwkwan
Copy link
Contributor

@kwkwan kwkwan commented Dec 6, 2024

Metanorma PR checklist

@kwkwan kwkwan linked an issue Dec 6, 2024 that may be closed by this pull request
Add lutaml_express_liquid to render EXPRESS liquid drops #167
Open
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 6, 2024
View reviewed changes
lib/metanorma/plugin/lutaml/lutaml_preprocessor.rb
end

def lutaml_liquid?(line)
line.match(/^\[(?:\blutaml\b|\blutaml_express\b|\blutaml_express_liquid\b),(?<index_names>[^,]+)?,?(?<context_name>[^,]+)?(?<options>,.*)?\]/) # rubocop:disable Layout/LineLength

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
Loading
that depends on a
library input
Loading
may run slow on strings with many repetitions of '++'.
@kwkwan
Copy link
Contributor Author

kwkwan commented Dec 6, 2024

At 0e3bfec, lutaml_express_liquid will process EXPRESS files as Liquid Drops models. lutaml and lutaml_express will becomes the aliases of lutaml_express_liquid and perform the same thing as lutaml_express_liquid. Therefore, when using lutaml-express-index, users do not need to change the name of macro from lutaml or lutaml_express to lutaml_express_liquid to process EXPRESS files as Liquid Drops models.

The old methods and codes to process EXPRESS files will be removed later. The option leveloffset will also be removed later.

@kwkwan
Copy link
Contributor Author

kwkwan commented Dec 6, 2024

This PR is still under development. Please do not merge this PR at this moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add lutaml_express_liquid to render EXPRESS liquid drops
1 participant
@kwkwan