Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better internal error handling #17

Merged
merged 4 commits into from
Nov 27, 2022
Merged

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2022

Codecov Report

Base: 93.91% // Head: 93.91% // No change to project coverage 👍

Coverage data is based on head (673c5de) compared to base (a4272c2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files           4        4           
  Lines         312      312           
=======================================
  Hits          293      293           
  Misses         19       19           
Flag Coverage Δ
unittests 93.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@XuehaiPan XuehaiPan requested a review from JieRen98 November 26, 2022 08:12
@XuehaiPan XuehaiPan added the enhancement New feature or request label Nov 26, 2022
@XuehaiPan XuehaiPan force-pushed the debugging branch 5 times, most recently from 4dfba0f to 865d80b Compare November 26, 2022 10:59
@XuehaiPan XuehaiPan force-pushed the debugging branch 15 times, most recently from 0459356 to 1177d8a Compare November 26, 2022 16:13
@XuehaiPan XuehaiPan force-pushed the debugging branch 3 times, most recently from 915ba23 to 1c92b16 Compare November 26, 2022 18:27
@XuehaiPan XuehaiPan force-pushed the debugging branch 3 times, most recently from cb2465c to 1819a59 Compare November 26, 2022 19:49
@XuehaiPan XuehaiPan merged commit 9fda41e into metaopt:main Nov 27, 2022
@XuehaiPan XuehaiPan deleted the debugging branch November 27, 2022 09:54
@XuehaiPan XuehaiPan added the cxx Something related to the CXX source code label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx Something related to the CXX source code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants