MTG-819 Add metrics for data processing time #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanChe
reviewed
Oct 28, 2024
metrics_utils/src/lib.rs
Outdated
| pub fn new() -> Self { | ||
| Self { | ||
| accounts_read: Family::<MetricLabel, Histogram>::new_with_constructor(|| { | ||
| Histogram::new(exponential_buckets(1.0, 1.8, 10)) |
There was a problem hiding this comment.
I'd revise this, as it'll have buckets up to 357ms, which seems to be too low
metrics_utils/src/lib.rs
Outdated
| @@ -119,6 +121,61 @@ pub struct MetricLabelWithStatus { | |||
| pub status: MetricStatus, | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
| pub struct MessageProcessMetricsConfig { | |||
| accounts_read: Family<MetricLabel, Histogram>, | |||
There was a problem hiding this comment.
do we need 2, or just an additional label for account/transaction maybe?
There was a problem hiding this comment.
Below you're using this label already, so this may be the same family
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds new metrics - MessageProcessMetricsConfig.
Why
It will allow us to see how fast indexer process data received from Geyser plugin.
How
Metric call was added to main accounts and transactions processing functions. By main functions I mean functions where we extract data from Redis(or TCP connection), call processor and then call acknowledge. It means that during backfill processes that metrics will not be changed.