Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back Optional type import #144

Merged
merged 1 commit into from
Jan 13, 2022
Merged

fix: add back Optional type import #144

merged 1 commit into from
Jan 13, 2022

Conversation

zkhalapyan
Copy link
Contributor

@zkhalapyan zkhalapyan commented Jan 13, 2022

#138 removed the inclusive import of ./shared preventing Optional from getting imported properly, breaking external builds. See issue: metaplex-foundation/js#139.

PR converges all types under types.ts and directly imports Optional.

Tested that external builds work by manually importing the local forked npm package via npm link and building using tsc.

fixes #139

@aheckmann aheckmann self-assigned this Jan 13, 2022
Copy link
Contributor

@aheckmann aheckmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested against wonka to confirm the fix. landing this, thanks!

will handle creating a reproducible test scenario for this separately so we avoid this in the future.

@aheckmann aheckmann merged commit 4b933d4 into metaplex-foundation:main Jan 13, 2022
@zaxozhu
Copy link
Contributor

zaxozhu commented Jan 13, 2022

🎉 This PR is included in version 4.11.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find name 'Optinal'
3 participants