feat: added new actions for metadata program #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using
metaplex/js
for a project and ended up writing some of the actions that were missing.A few things to point out:
UpdateMetadata
, where because the below 2 lines were set to= null
, borsh wasn't serializing data properly.= null
was needed. Through trial and error removing it seems to fix the issue and didn't break any other tests.Finally, I've left a few comments in the code to clarify parts I found confusing when coding this. I noticed the repo is basically comment-free - if that's an intentional decision, more than happy to remove. But I do think they're useful.
Hope this is useful!