Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wallet adapter dependency #116

Merged
merged 2 commits into from
May 26, 2022
Merged

Remove wallet adapter dependency #116

merged 2 commits into from
May 26, 2022

Conversation

lorisleiva
Copy link
Contributor

@lorisleiva lorisleiva commented May 26, 2022 •
edited
Loading

Currently: We are requiring the @solana/wallet-adapter-base package just to import its WalletAdapter type. The issue is we require the entire type when we only need a subset of it. This can cause type errors like #113.

After this PR: We expose our own WalletAdapter type definition cherry-picking what we need from that library without depending on it.

Fix #113

@lorisleiva lorisleiva self-assigned this May 26, 2022
@lorisleiva lorisleiva requested a review from thlorenz May 26, 2022 12:38
thlorenz
thlorenz approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@thlorenz thlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorisleiva lorisleiva merged commit 2bb531e into main May 26, 2022
thlorenz added a commit that referenced this pull request May 28, 2022
@thlorenz
Merge branch 'main' into thlorenz/feat/upload
aa4a05e 
* main:
  Refactor Storage Module (#117)
  Remove wallet adapter dependency (#116)
@lorisleiva lorisleiva deleted the loris/fix-wallet-adapter-type branch May 30, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thlorenz thlorenz thlorenz approved these changes

Assignees

@lorisleiva lorisleiva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

walletAdapterIdenity is showing type error when used with useWallet.
2 participants
@lorisleiva @thlorenz