Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experimental] Use account name directly for data types and codecs #212

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

lorisleiva
Copy link
Collaborator

Assuming an AccountNode named Token, this PR makes the following changes to the generated client for the new web3.js:

// Before.
export type TokenAccountData = { ... }; // Data.
export type Token = Account<TokenAccountData>;
export type MaybeToken = MaybeAccount<TokenAccountData>;

// After.
export type Token = { ... }; // Data.
// Just use `Account<Token>` and `MaybeAccount<Token>` directly when needed.

Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: 3e64e84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@metaplex-foundation/kinobi Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lorisleiva lorisleiva self-assigned this Apr 15, 2024
@lorisleiva lorisleiva merged commit 8cb70c8 into main Apr 15, 2024
6 checks passed
@lorisleiva lorisleiva deleted the loris/update-account-types branch April 15, 2024 10:10
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant