Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bare bones error handling to network driver #100

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

Funkatronics
Copy link
Contributor

Description

  • Added barebones error handing to the network driver.

Work Completed

  • The default network driver (JdkHttpDriver) is currently throwing fatal exceptions of the response returns an error in the error stream instead of the input stream
  • This change also checks the error stream if the input stream is null

API Changes

  • none

Testing

  • ran all unit tests, verified that this change does not impact any existing calls or error handling
  • confirmed this change works while developing shadow drive integration, confirmed that both successful response and errors are handled by the driver without crashing

Copy link
Contributor

@ajamaica ajamaica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go in

@ajamaica ajamaica merged commit 19a8410 into main Feb 6, 2023
@ajamaica ajamaica deleted the martini/network-driver-error-handling branch February 6, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants