Skip to content
This repository has been archived by the owner on Jun 29, 2021. It is now read-only.

Update to new faye-websocket/websocket-driver with new http parser #160

Closed
sdarnell opened this issue Aug 1, 2017 · 3 comments
Closed

Comments

@sdarnell
Copy link

sdarnell commented Aug 1, 2017

As per meteor/meteor#8648 I discovered a problem with the websocket-driver package used by faye-websocket. It was causing an assert in debug builds of node, and there is a chance that it also results in some form of memory corruption on refresh - though it is hard to say for certain.

The websocket-driver code has been updated to use a new http parser and avoid using node internals. So this feature request is a placeholder to make sure it gets updated when the faye-websocket/websocket-driver gets released.

See faye/websocket-driver-node#21

I have manually dropped in replacements and it seems to work in meteor, but I'm unable to reproduce the crashes that others are seeing so I can't be certain whether it fixes meteor/meteor#8648

@sdarnell
Copy link
Author

sdarnell commented Aug 1, 2017

For reference, the current (old) versions are:
faye-websocket: 0.11.1 https://www.npmjs.com/package/faye-websocket
websocket-driver: 0.6.5 https://www.npmjs.com/package/websocket-driver

@hwillson
Copy link
Contributor

hwillson commented Aug 1, 2017

Thanks @sdarnell - I've marked this as pull-requests-encouraged. If anyone is interested in working on this, please wait until after the changes from faye/websocket-driver-node#21 have been published and made available via a new faye-websocket release.

@abernix
Copy link
Contributor

abernix commented Sep 4, 2017

Closing this as the PR has been merged. This will land in Meteor 1.5.2 and beyond. Thanks very much, @sdarnell!

@abernix abernix closed this as completed Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants