meteor run can leak processes without webapp module
#3315
Milestone
Comments
glasser
added a commit
that referenced
this issue
Jan 3, 2015
This commit moves parent pid process from the webapp package to the boot script. This means that daemonized apps without webapp will also exit when the runner exits, if run from the runner. (For example, several self-tests such as 'autoupdate' no longer leak node processes.) This is controlled via the $METEOR_PARENT_PID environment variable instead of from command line arguments, in order to make fewer assumptions about how Meteor apps process arguments. This also drops the old --keepalive support (which already has stopped being used by the dev mode runner or any MDG deployment platforms). Neither --parent-pid nor --keepalive were documented beforehand, and --keepalive was already deprecated before 1.0. These flags used to also incidentally trigger printing the LISTENING line; this is now controlled by $METEOR_PRINT_ON_LISTEN. Fixes #3315.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We switched from keepalive to "app polls a parent pid" but this doesn't work if the app lacks
webapp. We should move this check to boot.js (and maybe make it configured via env var instead of command-line option). eg, right now theautoupdateself-test leaks a process.The text was updated successfully, but these errors were encountered: