This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
Updated Mocha based tests to remove arrow functions. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I wonder if there is some simple way to get the linter to be happy about it. Maybe we just need to disable those rules entirely... |
|
We could disable those rules for the entire project, but ideally we'd just disable them for the tests. The good news is that eslint is working on a glob based config option. This would really help! |
|
Yeah! That would be awesome. In general relaxing lint rules for tests makes a lot of sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys - I've updated the Mocha based tests to remove arrow functions (recommended against by Mocha). These changes are associated with the Guide changes discussed in meteor/guide#318. Thanks!