Skip to content

Commit

Permalink
Windows, launcher: support python/bash toolchain
Browse files Browse the repository at this point in the history
  • Loading branch information
meteorcloudy committed May 22, 2019
1 parent 6f52cf3 commit dc91ade
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/tools/launcher/bash_launcher.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ static constexpr const char* BASH_BIN_PATH = "bash_bin_path";

ExitCode BashBinaryLauncher::Launch() {
wstring bash_binary = this->GetLaunchInfoByKey(BASH_BIN_PATH);

bash_binary = this->Rlocation(bash_binary, true);

if (DoesFilePathExist(bash_binary.c_str())) {
wstring bash_bin_dir = GetParentDirFromPath(bash_binary);
wstring path_env;
Expand Down
3 changes: 3 additions & 0 deletions src/tools/launcher/python_launcher.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ static constexpr const char* WINDOWS_STYLE_ESCAPE_JVM_FLAGS = "escape_args";

ExitCode PythonBinaryLauncher::Launch() {
wstring python_binary = this->GetLaunchInfoByKey(PYTHON_BIN_PATH);

python_binary = this->Rlocation(python_binary, true);

// If specified python binary path doesn't exist, then fall back to
// python.exe and hope it's in PATH.
if (!DoesFilePathExist(python_binary.c_str())) {
Expand Down

0 comments on commit dc91ade

Please sign in to comment.