Windows, build-runfiles: Implement build-runfiles for Windows

Working towards: bazelbuild#5807 Change-Id: Iae10ff439bb3e8513c44ebfc4c174409623991d9
meteorcloudy · Aug 29, 2018 · f236c65 · f236c65
1 parent 206c19b
commit f236c65
Show file tree

Hide file tree

Showing 7 changed files with 551 additions and 51 deletions.
diff --git a/src/main/cpp/util/BUILD b/src/main/cpp/util/BUILD
@@ -55,6 +55,7 @@ cc_library(
     visibility = [
         ":ijar",
         "//src/test/cpp/util:__pkg__",
+        "//src/main/tools:__pkg__",
         "//src/tools/launcher:__subpackages__",
         "//src/tools/singlejar:__pkg__",
         "//third_party/def_parser:__pkg__",

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java
@@ -1167,10 +1167,6 @@ public void reportInvalidOptions(EventHandler reporter) {
       fragment.reportInvalidOptions(reporter, this.buildOptions);
     }
 
-    if (OS.getCurrent() == OS.WINDOWS && runfilesEnabled()) {
-      reporter.handle(Event.error("building runfiles is not supported on Windows"));
-    }
-
     if (options.outputDirectoryName != null) {
       reporter.handle(Event.error(
           "The internal '--output directory name' option cannot be used on the command line"));

diff --git a/src/main/tools/BUILD b/src/main/tools/BUILD
@@ -48,6 +48,7 @@ cc_binary(
         "//src/conditions:windows": ["build-runfiles-windows.cc"],
         "//conditions:default": ["build-runfiles.cc"],
     }),
+    deps = ["//src/main/cpp/util:filesystem"],
 )
 
 cc_binary(