fix git_add resource #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 9, 2022 13:45
Using worktree.AddWithOptions does not work as documented: 1) Setting All to true always adds all added/modified files, even if Path or Glob is specified 2) Setting All to true does not add deleted files even In order to work around this, worktree.Add is called instead, and we are iterating manually over the current worktree.Status to get all files that somehow changed (including the deleted ones).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change!
allattribute was removed entirely. Thegit_addresource now always adds files to the index even if those files are deleted.exact_pathandglob_pathattributes were merged intoadd_pathswhich is a list of strings and accepts both exact paths to files/directories as well as glob patterns or a mixture of them.idattribute now contains the unix nanoseconds of the last addition.These changes were necessary because upstream go-git is buggy when it comes to adding 'all' files (see go-git/go-git#223). The workaround implemented here uses
worktree.Addinstead ofworktree.AddWithOptionswhich seems to work as expected. Acceptance tests with terratest were added that verify the wanted behavior.